-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FirmwareFlasher] Adds Configuration file & Edit Menu + Minor Text Changes #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jomik
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally I would expect a class Config
which handled all the configuration reading and saving, etc.
Isolated and concerned with just that one thing.
Jomik
reviewed
Dec 13, 2024
Jomik
approved these changes
Dec 13, 2024
krautech
added a commit
that referenced
this pull request
Dec 13, 2024
…anges (#194) * initial commit * Initial Commit * Add header * Updated * Add reset to defaults * fix KATAPULT_DIR * just a shit ton of changes, whoops * fixes menu return on firmware select
krautech
added a commit
that referenced
this pull request
Jan 9, 2025
…anges (#194) * initial commit * Initial Commit * Add header * Updated * Add reset to defaults * fix KATAPULT_DIR * just a shit ton of changes, whoops * fixes menu return on firmware select
RichardTHF
pushed a commit
that referenced
this pull request
Jan 9, 2025
* [FirmwareFlasher] Change text from find to select firmware (#183) * increment version number * change Find to Select (Firmware) * fix -f arg not starting at that specific menu (#184) * move dfu flash to advanced menu (#185) * add restart_klipper function (#186) * [FirmwareFlasher] Updates Katapult and Checks Origin (#187) * mandatory katapult update + check prior * split KatapultInstaller into smaller functions * remove firmware.sh (#181) * change menu calls to returns (#193) * [FirmwareFlasher] Adds logging (#191) * adds logging * remove clear handlers * fix color to error message * removed logging_debug * adds INFO only filter * [FirmwareFlasher] Query DFU Device Inf Loop + Anykey Exit (#192) * dfu loop without timeout * removed extra func * [FirmwareFlasher] Adds Configuration file & Edit Menu + Minor Text Changes (#194) * initial commit * Initial Commit * Add header * Updated * Add reset to defaults * fix KATAPULT_DIR * just a shit ton of changes, whoops * fixes menu return on firmware select * [FirmwareFlasher] Repository would error when case-sensitive - 0.0.4 (#197) * make lowercase * increment * [FirmwareFlasher] Normalise GIT repo origin (#201) * add firmware.cfg to gitignore * increment to 0.0.6 * normalize katapult repo url to remove .git * removed increment * [FirmwareFlasher] Add LSUSB (/dev/ Directory to Config Options (#200) * Adds DEV_DIR and increment to 0.0.7 * removed increment * [FirmwareFlasher] Adds Advanced Menu for All Firmware (#198) * Adds menu for All Firmware * removed increment * menu item text change * fixes klippy env path (#206) * verify that no one is attempting to flash cartographer directly on creality os or other build root based environments (#218) (#219) Co-authored-by: Jason Pell <[email protected]> --------- Co-authored-by: Jason Pell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows users ability to edit directories for non standard installations. Includes defaults of
File will be created and saved as firmware.cfg in the scripts folder if a user sets custom values from the menu.