Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FirmwareFlasher] Adds Configuration file & Edit Menu + Minor Text Changes #194

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

krautech
Copy link
Collaborator

Description

Allows users ability to edit directories for non standard installations. Includes defaults of

  • KLIPPY_LOG = ~/printer_data/logs/klippy.log
  • KATAPULT_DIR = ~/katapult
  • KLIPPER = ~/klipper
  • KLIPPY_ENV = ~/klippy_env

File will be created and saved as firmware.cfg in the scripts folder if a user sets custom values from the menu.

image
image

@krautech krautech added the feature New feature or request label Dec 13, 2024
@krautech krautech requested review from Jomik and RichardTHF December 13, 2024 05:24
@krautech krautech self-assigned this Dec 13, 2024
Copy link
Collaborator

@Jomik Jomik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would expect a class Config which handled all the configuration reading and saving, etc.
Isolated and concerned with just that one thing.

scripts/firmware.py Show resolved Hide resolved
scripts/firmware.py Outdated Show resolved Hide resolved
scripts/firmware.py Outdated Show resolved Hide resolved
@krautech krautech requested a review from Jomik December 13, 2024 11:01
@krautech krautech merged commit bffe161 into develop Dec 13, 2024
3 checks passed
@krautech krautech deleted the feat/add-custom-dir-menu-ff branch December 13, 2024 11:29
krautech added a commit that referenced this pull request Dec 13, 2024
…anges (#194)

* initial commit

* Initial Commit

* Add header

* Updated

* Add reset to defaults

* fix KATAPULT_DIR

* just a shit ton of changes, whoops

* fixes menu return on firmware select
krautech added a commit that referenced this pull request Jan 9, 2025
…anges (#194)

* initial commit

* Initial Commit

* Add header

* Updated

* Add reset to defaults

* fix KATAPULT_DIR

* just a shit ton of changes, whoops

* fixes menu return on firmware select
RichardTHF pushed a commit that referenced this pull request Jan 9, 2025
* [FirmwareFlasher] Change text from find to select firmware (#183)

* increment version number

* change Find to Select (Firmware)

* fix -f arg not starting at that specific menu (#184)

* move dfu flash to advanced menu (#185)

* add restart_klipper function (#186)

* [FirmwareFlasher] Updates Katapult and Checks Origin (#187)

* mandatory katapult update + check prior

* split KatapultInstaller into smaller functions

* remove firmware.sh (#181)

* change menu calls to returns (#193)

* [FirmwareFlasher] Adds logging (#191)

* adds logging

* remove clear handlers

* fix color to error message

* removed logging_debug

* adds INFO only filter

* [FirmwareFlasher] Query DFU Device Inf Loop + Anykey Exit (#192)

* dfu loop without timeout

* removed extra func

* [FirmwareFlasher] Adds Configuration file & Edit Menu + Minor Text Changes (#194)

* initial commit

* Initial Commit

* Add header

* Updated

* Add reset to defaults

* fix KATAPULT_DIR

* just a shit ton of changes, whoops

* fixes menu return on firmware select

* [FirmwareFlasher] Repository would error when case-sensitive - 0.0.4 (#197)

* make lowercase

* increment

* [FirmwareFlasher] Normalise GIT repo origin (#201)

* add firmware.cfg to gitignore

* increment to 0.0.6

* normalize katapult repo url to remove .git

* removed increment

* [FirmwareFlasher] Add LSUSB (/dev/ Directory to Config Options (#200)

* Adds DEV_DIR and increment to 0.0.7

* removed increment

* [FirmwareFlasher] Adds Advanced Menu for All Firmware (#198)

* Adds menu for All Firmware

* removed increment

* menu item text change

* fixes klippy env path (#206)

* verify that no one is attempting to flash cartographer directly on creality os or other build root based environments (#218) (#219)

Co-authored-by: Jason Pell <[email protected]>

---------

Co-authored-by: Jason Pell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants